ext4: add ext4_mb_unload_buddy in the error path
authorSalman Qazi <sqazi@google.com>
Fri, 1 Jun 2012 03:51:27 +0000 (23:51 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Fri, 1 Jun 2012 03:51:27 +0000 (23:51 -0400)
ext4_free_blocks fails to pair an ext4_mb_load_buddy with a matching
ext4_mb_unload_buddy when it fails a memory allocation.

Signed-off-by: Salman Qazi <sqazi@google.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: stable@kernel.org
fs/ext4/mballoc.c

index e4b4ac1ec684a4025a25525c5bda34a838462046..3d9277c48bc87bde7fe1afff5c1b09c0ac6f97b3 100644 (file)
@@ -4634,6 +4634,7 @@ do_more:
                 */
                new_entry = kmem_cache_alloc(ext4_free_data_cachep, GFP_NOFS);
                if (!new_entry) {
+                       ext4_mb_unload_buddy(&e4b);
                        err = -ENOMEM;
                        goto error_return;
                }