dmaengine: mxs: remove NO_IRQ check
authorArnd Bergmann <arnd@arndb.de>
Fri, 2 Sep 2016 23:01:06 +0000 (01:01 +0200)
committerVinod Koul <vinod.koul@intel.com>
Mon, 5 Sep 2016 11:10:52 +0000 (16:40 +0530)
The mxs_chan->chan_irq variable is guaranteed to never be NO_IRQ,
as it gets assigned the result of platform_get_irq() that returns
either a valid positive interrupt number, or a negative failure
code that leads to the channel not being used.

This removes the redundant check, eliminating one more instance
of NO_IRQ.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
drivers/dma/mxs-dma.c

index 60de35251da5d3950442a310f82f6311ef50783a..1e3572bb7012823c83b0a7db5213be7c0eb50cf7 100644 (file)
@@ -429,12 +429,10 @@ static int mxs_dma_alloc_chan_resources(struct dma_chan *chan)
                goto err_alloc;
        }
 
-       if (mxs_chan->chan_irq != NO_IRQ) {
-               ret = request_irq(mxs_chan->chan_irq, mxs_dma_int_handler,
-                                       0, "mxs-dma", mxs_dma);
-               if (ret)
-                       goto err_irq;
-       }
+       ret = request_irq(mxs_chan->chan_irq, mxs_dma_int_handler,
+                         0, "mxs-dma", mxs_dma);
+       if (ret)
+               goto err_irq;
 
        ret = clk_prepare_enable(mxs_dma->clk);
        if (ret)