9p: fix bad error path in conversion routines
authorMariusz Kozlowski <m.kozlowski@tuxland.pl>
Thu, 23 Aug 2007 15:24:28 +0000 (10:24 -0500)
committerEric Van Hensbergen <ericvh@ericvh-laptop.austin.ibm.com>
Thu, 23 Aug 2007 15:25:05 +0000 (10:25 -0500)
When buf_check_overflow() returns != 0 we will hit kfree(ERR_PTR(err))
and it will not be happy about it.

Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Signed-off-by: Eric Van Hensbergen <ericvh@gmail.com>
net/9p/conv.c

index f2a041cb508a146264c9230368fa15acdcf9050b..d979d958ea199c88dea062fa9fa6f797872fda6a 100644 (file)
@@ -796,6 +796,7 @@ struct p9_fcall *p9_create_twrite_u(u32 fid, u64 offset, u32 count,
        if (err) {
                kfree(fc);
                fc = ERR_PTR(err);
+               goto error;
        }
 
        if (buf_check_overflow(bufp)) {