NFSD: Put export if prepare_creds() fail
authorKinglong Mee <kinglongmee@gmail.com>
Tue, 2 Sep 2014 14:15:26 +0000 (22:15 +0800)
committerJ. Bruce Fields <bfields@redhat.com>
Wed, 3 Sep 2014 21:43:04 +0000 (17:43 -0400)
Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
fs/nfsd/nfsfh.c

index e883a5868be6212be3e4e9bf3b6073730566ef57..88026fc6a9817bcda327684b780160c1297e309d 100644 (file)
@@ -209,8 +209,10 @@ static __be32 nfsd_set_fh_dentry(struct svc_rqst *rqstp, struct svc_fh *fhp)
                 * fix that case easily.
                 */
                struct cred *new = prepare_creds();
-               if (!new)
-                       return nfserrno(-ENOMEM);
+               if (!new) {
+                       error =  nfserrno(-ENOMEM);
+                       goto out;
+               }
                new->cap_effective =
                        cap_raise_nfsd_set(new->cap_effective,
                                           new->cap_permitted);