ASoC: spear_pcm: No need to wrap snd_dmaengine_pcm_close()
authorLars-Peter Clausen <lars@metafoo.de>
Fri, 22 Mar 2013 13:12:02 +0000 (14:12 +0100)
committerMark Brown <broonie@opensource.wolfsonmicro.com>
Tue, 26 Mar 2013 14:14:29 +0000 (14:14 +0000)
If a PCM driver using the dmaengine PCM helper functions doesn't need to do
anything special in its pcm_close callback, snd_dmaengine_pcm_close can be used
directly for as the pcm_close callback and there is no need to wrap it in a
custom function.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Rajeev Kumar <rajeev-dlh.kumar@st.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
sound/soc/spear/spear_pcm.c

index 9b76cc5a114897613ed3d19e87b13b649037c4be..32431d6191740ba6f2875fbe840a5ffe6c9a15ab 100644 (file)
@@ -73,14 +73,6 @@ static int spear_pcm_open(struct snd_pcm_substream *substream)
        return 0;
 }
 
-static int spear_pcm_close(struct snd_pcm_substream *substream)
-{
-
-       snd_dmaengine_pcm_close(substream);
-
-       return 0;
-}
-
 static int spear_pcm_mmap(struct snd_pcm_substream *substream,
                struct vm_area_struct *vma)
 {
@@ -93,7 +85,7 @@ static int spear_pcm_mmap(struct snd_pcm_substream *substream,
 
 static struct snd_pcm_ops spear_pcm_ops = {
        .open           = spear_pcm_open,
-       .close          = spear_pcm_close,
+       .close          = snd_dmaengine_pcm_close,
        .ioctl          = snd_pcm_lib_ioctl,
        .hw_params      = spear_pcm_hw_params,
        .hw_free        = spear_pcm_hw_free,