mtd: nand: pxa3xx: Remove READ0 switch/case falltrough
authorEzequiel Garcia <ezequiel.garcia@free-electrons.com>
Thu, 14 Nov 2013 21:25:32 +0000 (18:25 -0300)
committerBrian Norris <computersforpeace@gmail.com>
Fri, 3 Jan 2014 19:22:12 +0000 (11:22 -0800)
READ0 and READOOB command preparation has a falltrough to SEQIN
case, where the command address is specified.
This is certainly confusing and makes the code less readable with
no added value. Let's remove it.

Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Tested-by: Daniel Mack <zonque@gmail.com>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
drivers/mtd/nand/pxa3xx_nand.c

index 4469163774014639843ccd5c20038d1758eb9d11..0fdcc91af1e25a02e0fa8f75a13f707b1ad72f04 100644 (file)
@@ -665,6 +665,11 @@ static int prepare_command_pool(struct pxa3xx_nand_info *info, int command,
                if (mtd->writesize >= PAGE_CHUNK_SIZE)
                        info->ndcb0 |= NDCB0_DBC | (NAND_CMD_READSTART << 8);
 
+               set_command_address(info, mtd->writesize, column, page_addr);
+               info->buf_count = mtd->writesize + mtd->oobsize;
+               memset(info->data_buff, 0xFF, info->buf_count);
+               break;
+
        case NAND_CMD_SEQIN:
 
                set_command_address(info, mtd->writesize, column, page_addr);