Fix delete button appears on failed uploads

diff --git a/ts/WoltLabSuite/Core/Ui/File/Delete.ts b/ts/WoltLabSuite/Core/Ui/File/Delete.ts
index 4a7898dce10cc02555849e8f1eb2274ff66fa8f3..d5d0646f786df71ab61fb0221bdbd81057e435fa 100644 (file)
--- a/ts/WoltLabSuite/Core/Ui/File/Delete.ts
+++ b/ts/WoltLabSuite/Core/Ui/File/Delete.ts
@@ -70,8 +70,12 @@ class UiFileDelete implements AjaxCallbackObject {
   private createButtons(): void {
     let triggerChange = false;
     this.target.querySelectorAll("li.uploadedFile").forEach((element: HTMLElement) => {
-      const uniqueFileId = element.dataset.uniqueFileId!;
-      if (this.containers.has(uniqueFileId)) {
+      const uniqueFileId = element.dataset.uniqueFileId;
+
+      // If the uniqueFileId is undefined, the upload has not succeded. For non succeded uploads
+      // we do not want a delete button, because the file is cleared automatically
+      // with the next upload.
+      if (uniqueFileId === undefined || this.containers.has(uniqueFileId)) {
         return;
       }
 

diff --git a/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/File/Delete.js b/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/File/Delete.js
index 9e1ae00ff0a44379ae33a549006c48da51118128..ee731ff2a31507caf435a2ddf034bb3cb1ec47e9 100644 (file)
--- a/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/File/Delete.js
+++ b/wcfsetup/install/files/js/WoltLabSuite/Core/Ui/File/Delete.js
@@ -44,7 +44,10 @@ define(["require", "exports", "tslib", "../../Ajax", "../../Core", "../../Dom/Ch
             let triggerChange = false;
             this.target.querySelectorAll("li.uploadedFile").forEach((element) => {
                 const uniqueFileId = element.dataset.uniqueFileId;
-                if (this.containers.has(uniqueFileId)) {
+                // If the uniqueFileId is undefined, the upload has not succeded. For non succeded uploads
+                // we do not want a delete button, because the file is cleared automatically
+                // with the next upload.
+                if (uniqueFileId === undefined || this.containers.has(uniqueFileId)) {
                     return;
                 }
                 const elementData = {