[media] si2157: cancel_delayed_work_sync before device removal / kfree
authorErnst Martin Witte <emw-linux-kernel@nocabal.de>
Sat, 9 Jan 2016 20:18:43 +0000 (18:18 -0200)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Mon, 1 Feb 2016 11:41:38 +0000 (09:41 -0200)
si2157_remove  was  calling  kfree(dev)  with  possibly  still  active
schedule_delayed_work(dev->stat_work).  This  caused kernel  panics in
call_timer_fn e.g. after rmmod cx23885.

Signed-off-by: Ernst Martin Witte <emw-linux-kernel@nocabal.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/media/tuners/si2157.c

index 5da5b421d31033dbc42932a631903d422060c3b6..3450dfb7c427ad1841cfa31cde2647eee31fde72 100644 (file)
@@ -458,6 +458,9 @@ static int si2157_remove(struct i2c_client *client)
 
        dev_dbg(&client->dev, "\n");
 
+       /* stop statistics polling */
+       cancel_delayed_work_sync(&dev->stat_work);
+
        memset(&fe->ops.tuner_ops, 0, sizeof(struct dvb_tuner_ops));
        fe->tuner_priv = NULL;
        kfree(dev);