scsi: lpfc: ensure els_wq is being checked before destroying it
authorColin Ian King <colin.king@canonical.com>
Sat, 6 May 2017 22:13:55 +0000 (23:13 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 9 May 2017 02:10:25 +0000 (22:10 -0400)
I believe there is a typo on the wq destroy of els_wq, currently the
driver is checking if els_cq is not null and I think this should be a
check on els_wq instead.

Detected by CoverityScan, CID#1411629 ("Copy-paste error")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/lpfc/lpfc_init.c

index e85f273e34ac0108fbc86567acaf3811a7663528..4b1eb98c228df823a986f5568f8b948a7b2ef9bf 100644 (file)
@@ -8854,7 +8854,7 @@ lpfc_sli4_queue_unset(struct lpfc_hba *phba)
                lpfc_wq_destroy(phba, phba->sli4_hba.nvmels_wq);
 
        /* Unset ELS work queue */
-       if (phba->sli4_hba.els_cq)
+       if (phba->sli4_hba.els_wq)
                lpfc_wq_destroy(phba, phba->sli4_hba.els_wq);
 
        /* Unset unsolicited receive queue */