leds: bcm6328: remove unneded lock when checking initial LED
authorÁlvaro Fernández Rojas <noltari@gmail.com>
Tue, 15 Dec 2015 20:03:46 +0000 (21:03 +0100)
committerJacek Anaszewski <j.anaszewski@samsung.com>
Mon, 4 Jan 2016 08:57:39 +0000 (09:57 +0100)
This lock isn't really needed, since we're only reading the register and
changes made to other LEDs aren't relevant.

Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Signed-off-by: Jacek Anaszewski <j.anaszewski@samsung.com>
drivers/leds/leds-bcm6328.c

index 1ef69c27a6a7f2a6a4b7f5da286b8f80f9dc4538..cd542641e38d6f31b41d6d08d39e5a2fadf21780 100644 (file)
@@ -264,7 +264,6 @@ static int bcm6328_led(struct device *dev, struct device_node *nc, u32 reg,
                       unsigned long *blink_leds, unsigned long *blink_delay)
 {
        struct bcm6328_led *led;
-       unsigned long flags;
        const char *state;
        int rc;
 
@@ -286,7 +285,6 @@ static int bcm6328_led(struct device *dev, struct device_node *nc, u32 reg,
                                                    "linux,default-trigger",
                                                    NULL);
 
-       spin_lock_irqsave(lock, flags);
        if (!of_property_read_string(nc, "default-state", &state)) {
                if (!strcmp(state, "on")) {
                        led->cdev.brightness = LED_FULL;
@@ -314,7 +312,6 @@ static int bcm6328_led(struct device *dev, struct device_node *nc, u32 reg,
        } else {
                led->cdev.brightness = LED_OFF;
        }
-       spin_unlock_irqrestore(lock, flags);
 
        bcm6328_led_set(&led->cdev, led->cdev.brightness);