arm/arm64: KVM: vgic: kick the specific vcpu instead of iterating through all
authorShannon Zhao <zhaoshenglong@huawei.com>
Wed, 19 Nov 2014 10:11:25 +0000 (10:11 +0000)
committerMarc Zyngier <marc.zyngier@arm.com>
Wed, 26 Nov 2014 10:19:37 +0000 (10:19 +0000)
When call kvm_vgic_inject_irq to inject interrupt, we can known which
vcpu the interrupt for by the irq_num and the cpuid. So we should just
kick this vcpu to avoid iterating through all.

Reviewed-by: Christoffer Dall <christoffer.dall@linaro.org>
Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
virt/kvm/arm/vgic.c

index 631a472e41cff1b13413c0a934eaba042ba5efe5..21e035cc54602d9c3452e1780eaef66cca83c1af 100644 (file)
@@ -1607,7 +1607,7 @@ static int vgic_validate_injection(struct kvm_vcpu *vcpu, int irq, int level)
        }
 }
 
-static bool vgic_update_irq_pending(struct kvm *kvm, int cpuid,
+static int vgic_update_irq_pending(struct kvm *kvm, int cpuid,
                                  unsigned int irq_num, bool level)
 {
        struct vgic_dist *dist = &kvm->arch.vgic;
@@ -1673,7 +1673,7 @@ static bool vgic_update_irq_pending(struct kvm *kvm, int cpuid,
 out:
        spin_unlock(&dist->lock);
 
-       return ret;
+       return ret ? cpuid : -EINVAL;
 }
 
 /**
@@ -1693,9 +1693,14 @@ out:
 int kvm_vgic_inject_irq(struct kvm *kvm, int cpuid, unsigned int irq_num,
                        bool level)
 {
-       if (likely(vgic_initialized(kvm)) &&
-           vgic_update_irq_pending(kvm, cpuid, irq_num, level))
-               vgic_kick_vcpus(kvm);
+       int vcpu_id;
+
+       if (likely(vgic_initialized(kvm))) {
+               vcpu_id = vgic_update_irq_pending(kvm, cpuid, irq_num, level);
+               if (vcpu_id >= 0)
+                       /* kick the specified vcpu */
+                       kvm_vcpu_kick(kvm_get_vcpu(kvm, vcpu_id));
+       }
 
        return 0;
 }