usb: musb: blackfin: call gpio_free() on error path in musb_platform_init()
authorSergei Shtylyov <sshtylyov@ru.mvista.com>
Wed, 29 Sep 2010 06:54:31 +0000 (09:54 +0300)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 22 Oct 2010 17:21:59 +0000 (10:21 -0700)
Blackfin's musb_platform_init() needs to call gpio_free() for error cleanup iff
otg_get_transceiver() call returns NULL.

Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Acked-by: Mike Frysinger <vapier@gentoo.org>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/musb/blackfin.c

index 4fa25553c45003c46465272fa1bf39445c235778..611a9d274363ee90132e705ea61d8af1aa36657a 100644 (file)
@@ -342,8 +342,10 @@ int __init musb_platform_init(struct musb *musb, void *board_data)
 
        usb_nop_xceiv_register();
        musb->xceiv = otg_get_transceiver();
-       if (!musb->xceiv)
+       if (!musb->xceiv) {
+               gpio_free(musb->config->gpio_vrsel);
                return -ENODEV;
+       }
 
        if (ANOMALY_05000346) {
                bfin_write_USB_APHY_CALIB(ANOMALY_05000346_value);