projects
/
GitHub
/
exynos8895
/
android_kernel_samsung_universal8895.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
6371fe5
)
HID: prodikeys: kfree() NULL pointer cleanup
author
Bojan Prtvar
<prtvar.b@gmail.com>
Thu, 4 Aug 2011 21:46:48 +0000
(23:46 +0200)
committer
Jiri Kosina
<jkosina@suse.cz>
Thu, 4 Aug 2011 21:51:29 +0000
(23:51 +0200)
No need for freeing pm in case when it's not allocated.
Reported-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Bojan Prtvar <prtvar.b@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
drivers/hid/hid-prodikeys.c
patch
|
blob
|
blame
|
history
diff --git
a/drivers/hid/hid-prodikeys.c
b/drivers/hid/hid-prodikeys.c
index 158b389d0fb796156a7f0a8e6ec368cd91c8f875..f779009104eb93f79b29c94d8eef84561d1e468a 100644
(file)
--- a/
drivers/hid/hid-prodikeys.c
+++ b/
drivers/hid/hid-prodikeys.c
@@
-816,7
+816,7
@@
static int pk_probe(struct hid_device *hdev, const struct hid_device_id *id)
if (pm == NULL) {
hid_err(hdev, "can't alloc descriptor\n");
ret = -ENOMEM;
- goto err_free;
+ goto err_free
_pk
;
}
pm->pk = pk;
@@
-849,10
+849,10
@@
static int pk_probe(struct hid_device *hdev, const struct hid_device_id *id)
err_stop:
hid_hw_stop(hdev);
err_free:
- if (pm != NULL)
- kfree(pm);
-
+ kfree(pm);
+err_free_pk:
kfree(pk);
+
return ret;
}