regulator: gpio-regulator: Fix finding of smallest value
authorHeiko Stübner <heiko@sntech.de>
Sun, 3 Jun 2012 19:31:09 +0000 (21:31 +0200)
committerMark Brown <broonie@opensource.wolfsonmicro.com>
Mon, 4 Jun 2012 09:44:24 +0000 (10:44 +0100)
Commit 4dbd8f63f07a (regulator: gpio-regulator: Set the smallest
voltage/current in the specified range) forgot to set the newly
introduced best_val.

Therefore it stayed always at INT_MAX thus breaking the setting
of the voltage.

Included is also an init value for target, as warnings about
a possibly uninitialised target started appearing with this fix.

Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Acked-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
drivers/regulator/gpio-regulator.c

index ebe2b5c2e2df4c5b983559b928badd97d0aee51c..2c38bea5065ea2f7ff34712f44582eee579c3599 100644 (file)
@@ -104,13 +104,15 @@ static int gpio_regulator_set_value(struct regulator_dev *dev,
                                        int min, int max)
 {
        struct gpio_regulator_data *data = rdev_get_drvdata(dev);
-       int ptr, target, state, best_val = INT_MAX;
+       int ptr, target = 0, state, best_val = INT_MAX;
 
        for (ptr = 0; ptr < data->nr_states; ptr++)
                if (data->states[ptr].value < best_val &&
                    data->states[ptr].value >= min &&
-                   data->states[ptr].value <= max)
+                   data->states[ptr].value <= max) {
                        target = data->states[ptr].gpios;
+                       best_val = data->states[ptr].value;
+               }
 
        if (best_val == INT_MAX)
                return -EINVAL;