Input: do not emit unneeded EV_SYN when suspending
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Fri, 7 Aug 2015 02:15:30 +0000 (19:15 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Fri, 7 Aug 2015 21:55:38 +0000 (14:55 -0700)
Do not emit EV_SYN/SYN_REPORT on suspend if there were no keys that are
still pressed as we are suspending the device (and in all other cases when
input core is forcibly releasing keys via input_dev_release_keys() call).

Reviewed-by: Benson Leung <bleung@chromium.org>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/input.c

index 78d24990a816c10e6312108a316e61ddb8e164b9..5391abd28b2799c6776cf1bc8a398f70ed8382d7 100644 (file)
@@ -674,13 +674,19 @@ EXPORT_SYMBOL(input_close_device);
  */
 static void input_dev_release_keys(struct input_dev *dev)
 {
+       bool need_sync = false;
        int code;
 
        if (is_event_supported(EV_KEY, dev->evbit, EV_MAX)) {
-               for_each_set_bit(code, dev->key, KEY_CNT)
+               for_each_set_bit(code, dev->key, KEY_CNT) {
                        input_pass_event(dev, EV_KEY, code, 0);
+                       need_sync = true;
+               }
+
+               if (need_sync)
+                       input_pass_event(dev, EV_SYN, SYN_REPORT, 1);
+
                memset(dev->key, 0, sizeof(dev->key));
-               input_pass_event(dev, EV_SYN, SYN_REPORT, 1);
        }
 }