perf tools: Improve error reporting
authorAdrien BAK <adrien.bak@metascale.org>
Fri, 18 Apr 2014 02:00:43 +0000 (11:00 +0900)
committerJiri Olsa <jolsa@redhat.com>
Sat, 19 Apr 2014 22:15:12 +0000 (00:15 +0200)
commitffa91880a992ec1aaee4b4f7c9ddffda0c277ba9
tree2b0b1e74a2859a102e17cdfe96dc187db64481e0
parent922d0e4d9f042f68baea28e5b3bd7bb708875f2e
perf tools: Improve error reporting

In the current version, when using perf record, if something goes
wrong in tools/perf/builtin-record.c:375
  session = perf_session__new(file, false, NULL);

The error message:
"Not enough memory for reading per file header"

is issued. This error message seems to be outdated and is not very
helpful. This patch proposes to replace this error message by
"Perf session creation failed"

I believe this issue has been brought to lkml:
https://lkml.org/lkml/2014/2/24/458
although this patch only tackles a (small) part of the issue.

Additionnaly, this patch improves error reporting in
tools/perf/util/data.c open_file_write.

Currently, if the call to open fails, the user is unaware of it.
This patch logs the error, before returning the error code to
the caller.

Reported-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Adrien BAK <adrien.bak@metascale.org>
Link: http://lkml.kernel.org/r/1397786443.3093.4.camel@beast
[ Reorganize the changelog into paragraphs ]
[ Added empty line after fd declaration in open_file_write ]
Signed-off-by: Jiri Olsa <jolsa@redhat.com>
tools/perf/builtin-record.c
tools/perf/util/data.c