HID: hiddev: Fix slab-out-of-bounds write in hiddev_ioctl_usage()
authorPeilin Ye <yepeilin.cs@gmail.com>
Wed, 29 Jul 2020 11:37:12 +0000 (07:37 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 3 Sep 2020 09:22:34 +0000 (11:22 +0200)
commitff51a1a2dca3657a61d8df094587d7dee7c694d6
tree95e34b4df68080a63738c74c64d369cb83b23085
parent0a221a7442cc3a0da05cf97603ada6dcd6f33beb
HID: hiddev: Fix slab-out-of-bounds write in hiddev_ioctl_usage()

commit 25a097f5204675550afb879ee18238ca917cba7a upstream.

`uref->usage_index` is not always being properly checked, causing
hiddev_ioctl_usage() to go out of bounds under some cases. Fix it.

Reported-by: syzbot+34ee1b45d88571c2fa8b@syzkaller.appspotmail.com
Link: https://syzkaller.appspot.com/bug?id=f2aebe90b8c56806b050a20b36f51ed6acabe802
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Peilin Ye <yepeilin.cs@gmail.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hid/usbhid/hiddev.c