projects / GitHub / MotorolaMobilityLLC / kernel-slsi.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 46578a6) | patch
cassini/sungem: limit reaches -1, but 0 tested
authorRoel Kluin <roel.kluin@gmail.com>
Tue, 3 Feb 2009 07:19:50 +0000 (23:19 -0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 3 Feb 2009 07:19:50 +0000 (23:19 -0800)
commitff01b9163655ace76b29b7ff2f56b25c32f795da
treecde3ed89cb379d5e74216cff08077a38f2efd8aftree | snapshot (tar.gz zip)
parent46578a6913e6f5e69229561736b94c18c2e88ae4commit | diff
cassini/sungem: limit reaches -1, but 0 tested

while (limit--)
if (test())
break;

if (limit <= 0)
goto test_failed;

In the last iteration, limit is decremented after the test to 0.
If just thereafter test() succeeds and a break occurs, the goto
still occurs because limit is 0.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/cassini.c diff | blob | blame | history
drivers/net/sungem_phy.c diff | blob | blame | history
Motorola kernel-slsi