ext4: fix potential error in ext4_do_update_inode
authorShijie Luo <luoshijie1@huawei.com>
Fri, 12 Mar 2021 06:50:51 +0000 (01:50 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 24 Mar 2021 10:05:06 +0000 (11:05 +0100)
commitfe778c33aaa9c6ca0d9e90c16d07dd01cd3d8785
tree77d6bcaa05667b9c9fa4eed36a2d219ed1ba3d20
parent470f69cb3742e4c774ff2c89f6dbc691ba702926
ext4: fix potential error in ext4_do_update_inode

commit 7d8bd3c76da1d94b85e6c9b7007e20e980bfcfe6 upstream.

If set_large_file = 1 and errors occur in ext4_handle_dirty_metadata(),
the error code will be overridden, go to out_brelse to avoid this
situation.

Signed-off-by: Shijie Luo <luoshijie1@huawei.com>
Link: https://lore.kernel.org/r/20210312065051.36314-1-luoshijie1@huawei.com
Cc: stable@kernel.org
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/ext4/inode.c