media: cec-notifier: clear cec_adap in cec_notifier_unregister
authorHans Verkuil <hverkuil-cisco@xs4all.nl>
Fri, 23 Aug 2019 11:12:59 +0000 (08:12 -0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 5 Oct 2019 10:47:55 +0000 (12:47 +0200)
commitfdfcf82204737e45bfaa27a4fc65298990dfac07
treed2a9ad59e941e81ac3661d3a59c01cd736a7e14f
parent98a727a4db5162f20aabff15fe04e66255c5cf85
media: cec-notifier: clear cec_adap in cec_notifier_unregister

[ Upstream commit 14d5511691e5290103bc480998bc322e68f139d4 ]

If cec_notifier_cec_adap_unregister() is called before
cec_unregister_adapter() then everything is OK (and this is the
case today). But if it is the other way around, then
cec_notifier_unregister() is called first, and that doesn't
set n->cec_adap to NULL.

So if e.g. cec_notifier_set_phys_addr() is called after
cec_notifier_unregister() but before cec_unregister_adapter()
then n->cec_adap points to an unregistered and likely deleted
cec adapter. So just set n->cec_adap->notifier and n->cec_adap
to NULL for rubustness.

Eventually cec_notifier_unregister will disappear and this will
be simplified substantially.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/cec/cec-notifier.c