[media] v4l: rcar-fcp: Don't force users to check for disabled FCP support
authorLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Wed, 17 Aug 2016 12:57:37 +0000 (09:57 -0300)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Fri, 9 Sep 2016 14:29:57 +0000 (11:29 -0300)
commitfd44aa9a254b18176ec3792a18e7de6977030ca8
tree28358bebedc7e34df65cc4da9683a3a9fc9fa5e1
parent6eaafbdb668b09b1a06841ccddc405b31c216233
[media] v4l: rcar-fcp: Don't force users to check for disabled FCP support

The rcar_fcp_enable() function immediately returns successfully when the
FCP device pointer is NULL to avoid forcing the users to check the FCP
device manually before every call. However, the stub version of the
function used when the FCP driver is disabled returns -ENOSYS
unconditionally, resulting in a different API contract for the two
versions of the function.

As a user that requires FCP support will fail at probe time when calling
rcar_fcp_get() if the FCP driver is disabled, the stub version of the
rcar_fcp_enable() function will only be called with a NULL FCP device.
We can thus return 0 unconditionally to align the behaviour with the
normal version of the function.

Reported-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
include/media/rcar-fcp.h