drm/vc4: simplify exit path of a failed allocation of dsi_connector
authorColin Ian King <colin.king@canonical.com>
Fri, 3 Feb 2017 19:56:24 +0000 (19:56 +0000)
committerEric Anholt <eric@anholt.net>
Tue, 7 Feb 2017 23:27:25 +0000 (15:27 -0800)
commitfce6a7bc22114c69b071bcf6fbfea2d07de6273c
tree8ae9ca94c7cbb9d6f76c9315a782ea9198bc9b18
parent64b0e1d6c6a14dcbf0bde8b98207fc6b3569ce50
drm/vc4: simplify exit path of a failed allocation of dsi_connector

If dsi_connector fails to allocate, the exit path via label 'fail'
checks if connector is null, which it always is, so the cleanup
that destroys connector is never going to be called.  Hence the
failure path can be more optimally performed by removing this
and just returning ERR_PTR(-ENOMEM).  This also removes the need
to initialize connector to NULL, and we can also remove ret too.

Detected by CoverityScan, CID#1399504 ("Logicall Dead Code")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Eric Anholt <eric@anholt.net>
Reviewed-by: Gustavo Padovan <gustavo.padovan@collabora.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20170203195624.7189-1-colin.king@canonical.com
drivers/gpu/drm/vc4/vc4_dsi.c