vfs: read file_handle only once in handle_to_path
authorSasha Levin <sasha.levin@oracle.com>
Thu, 29 Jan 2015 02:30:43 +0000 (20:30 -0600)
committerStricted <info@stricted.net>
Thu, 11 Oct 2018 16:03:50 +0000 (18:03 +0200)
commitfbc6164ec2f90b96a753d719c498a96725834ea0
tree4482123641428cded825f55e6f9b279c44c01cf8
parent1e08ad13fd29c46412a4fbfa7394eed64d13974f
vfs: read file_handle only once in handle_to_path

We used to read file_handle twice. Once to get the amount of extra bytes, and
once to fetch the entire structure.

This may be problematic since we do size verifications only after the first
read, so if the number of extra bytes changes in userspace between the first
and second calls, we'll have an incoherent view of file_handle.

Instead, read the constant size once, and copy that over to the final
structure without having to re-read it again.

Change-Id: Ib05e5129629e27d5a05953098c5bc470fae40d2a
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
fs/fhandle.c