scsi: qla2xxxx: avoid type mismatch in comparison
authorArnd Bergmann <arnd@arndb.de>
Wed, 20 Jan 2016 10:47:14 +0000 (11:47 +0100)
committerNicholas Bellinger <nab@linux-iscsi.org>
Wed, 20 Jan 2016 11:03:24 +0000 (03:03 -0800)
commitfab683eb12e71ac6057dc42dc7d1e5e71e5cba5e
tree17f394abf79bb0d919843b02b4f2234e126e8c08
parent20c08b362f4b0c41103fe9d75c61ca348d021441
scsi: qla2xxxx: avoid type mismatch in comparison

A recent bug fix added code that does

        bool logged_out = (status & 0xFFFF);
        if (logged_out == CTIO_PORT_LOGGED_OUT)
...

This looks wrong because we are comparing a boolean with an
integer constant, ang gcc warns about it accordingly:

drivers/scsi/qla2xxx/qla_target.c: In function 'qlt_do_ctio_completion':
drivers/scsi/qla2xxx/qla_target.c:3587:20: warning: comparison of constant '41' with boolean expression is always false [-Wbool-compare]
        (logged_out == CTIO_PORT_LOGGED_OUT) ?

The correct fix is presumably to make that variable an 'int'.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 71cdc0796465 ("qla2xxx: Delete session if initiator is gone from FW")
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/scsi/qla2xxx/qla_target.c