tcp: fix FRTO undo on cumulative ACK of SACKed range
authorNeal Cardwell <ncardwell@google.com>
Thu, 2 Apr 2015 00:26:46 +0000 (20:26 -0400)
committerDanny Wood <danwood76@gmail.com>
Tue, 29 Jan 2019 13:07:51 +0000 (13:07 +0000)
commitfa56f429a2abedb32a0a999f789e3fd0cbe60558
treedd3c10df0012249b42e56d80abfebb5bf6b3bf52
parentec0b3532626439b522a853a941f9975995ed6838
tcp: fix FRTO undo on cumulative ACK of SACKed range

[ Upstream commit 666b805150efd62f05810ff0db08f44a2370c937 ]

On processing cumulative ACKs, the FRTO code was not checking the
SACKed bit, meaning that there could be a spurious FRTO undo on a
cumulative ACK of a previously SACKed skb.

The FRTO code should only consider a cumulative ACK to indicate that
an original/unretransmitted skb is newly ACKed if the skb was not yet
SACKed.

The effect of the spurious FRTO undo would typically be to make the
connection think that all previously-sent packets were in flight when
they really weren't, leading to a stall and an RTO.

Signed-off-by: Neal Cardwell <ncardwell@google.com>
Signed-off-by: Yuchung Cheng <ycheng@google.com>
Fixes: e33099f96d99c ("tcp: implement RFC5682 F-RTO")
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/ipv4/tcp_input.c