dp83640: don't recieve time stamps twice
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 18 Apr 2017 19:14:26 +0000 (22:14 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 3 May 2017 04:19:53 +0000 (21:19 -0700)
commitf6b34b1709acec5c7a4d83f43b52595466a32c37
tree7dbd42a19d6972ad9eee1d282079f7a68ba24fc8
parent78c4e3d4848d86c1ed36181c71c9c96834e910ed
dp83640: don't recieve time stamps twice

[ Upstream commit 9d386cd9a755c8293e8916264d4d053878a7c9c7 ]

This patch is prompted by a static checker warning about a potential
use after free.  The concern is that netif_rx_ni() can free "skb" and we
call it twice.

When I look at the commit that added this, it looks like some stray
lines were added accidentally.  It doesn't make sense to me that we
would recieve the same data two times.  I asked the author but never
recieved a response.

I can't test this code, but I'm pretty sure my patch is correct.

Fixes: 4b063258ab93 ("dp83640: Delay scheduled work.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Stefan Sørensen <stefan.sorensen@spectralink.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/phy/dp83640.c