projects / GitHub / LineageOS / android_kernel_motorola_exynos9610.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: b70661c) | patch
niu: fix error handling in niu_class_to_ethflow()
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 26 Feb 2015 16:56:56 +0000 (19:56 +0300)
committerDavid S. Miller <davem@davemloft.net>
Sat, 28 Feb 2015 17:58:25 +0000 (12:58 -0500)
commitf55ea3d932df06d82f37de5826063caf938c06f2
tree3caa216d102215e4bf8ae1adfb6575eeb5e2ce64tree | snapshot (tar.gz zip)
parentb70661c70830d5c69aab6844f2d86d2daf124fbdcommit | diff
niu: fix error handling in niu_class_to_ethflow()

There is a discrepancy here because the niu_class_to_ethflow() returns
zero on failure and one on success but the caller expected zero on
success and negative on failure.

The problem means that we allow the user to pass classes and flow_types
which we don't want.  I've looked at it a bit and I don't see it as a
very serious bug.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/sun/niu.c diff | blob | blame | history