xfrm: NULL dereference on allocation failure
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 14 Jun 2017 10:35:37 +0000 (13:35 +0300)
committerWilly Tarreau <w@1wt.eu>
Thu, 2 Nov 2017 06:16:29 +0000 (07:16 +0100)
commitf478b4264a3c62b6b2d2b63a707e56c2f0cfdc6c
treea66e90dfc866215a671602b0af477b9a6fb68db0
parent6ac502ceabf86463c4a35166851edf497960262f
xfrm: NULL dereference on allocation failure

commit e747f64336fc15e1c823344942923195b800aa1e upstream.

The default error code in pfkey_msg2xfrm_state() is -ENOBUFS.  We
added a new call to security_xfrm_state_alloc() which sets "err" to zero
so there several places where we can return ERR_PTR(0) if kmalloc()
fails.  The caller is expecting error pointers so it leads to a NULL
dereference.

Fixes: df71837d5024 ("[LSM-IPSec]: Security association restriction.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: Willy Tarreau <w@1wt.eu>
net/key/af_key.c