atl2: Disable unimplemented scatter/gather feature
authorBen Hutchings <ben@decadent.org.uk>
Wed, 20 Apr 2016 22:23:08 +0000 (23:23 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 21 Apr 2016 19:12:23 +0000 (15:12 -0400)
commitf43bfaeddc79effbf3d0fcb53ca477cca66f3db8
treef554d69becc4963d409eb153ababd1c89c5d255c
parent669c00c009ba0db81e840fd7e11faff7be8c8123
atl2: Disable unimplemented scatter/gather feature

atl2 includes NETIF_F_SG in hw_features even though it has no support
for non-linear skbs.  This bug was originally harmless since the
driver does not claim to implement checksum offload and that used to
be a requirement for SG.

Now that SG and checksum offload are independent features, if you
explicitly enable SG *and* use one of the rare protocols that can use
SG without checkusm offload, this potentially leaks sensitive
information (before you notice that it just isn't working).  Therefore
this obscure bug has been designated CVE-2016-2117.

Reported-by: Justin Yackoski <jyackoski@crypto-nite.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Fixes: ec5f06156423 ("net: Kill link between CSUM and SG features.")
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/atheros/atlx/atl2.c