block: Do a full clone when splitting discard bios
authorMartin K. Petersen <martin.petersen@oracle.com>
Wed, 22 Jul 2015 11:57:12 +0000 (07:57 -0400)
committerJens Axboe <axboe@fb.com>
Thu, 23 Jul 2015 22:21:34 +0000 (16:21 -0600)
commitf3f5da624e0a891c34d8cd513c57f1d9b0c7dadc
treed2a92a8d8d03287c8b51df5dfae24d267e151e6b
parent5aa2a96b34073fb775917fbc7d5578a04164b9f7
block: Do a full clone when splitting discard bios

This fixes a data corruption bug when using discard on top of MD linear,
raid0 and raid10 personalities.

Commit 20d0189b1012 "block: Introduce new bio_split()" permits sharing
the bio_vec between the two resulting bios. That is fine for read/write
requests where the bio_vec is immutable. For discards, however, we need
to be able to attach a payload and update the bio_vec so the page can
get mapped to a scatterlist entry. Therefore the bio_vec can not be
shared when splitting discards and we must do a full clone.

Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Reported-by: Seunguk Shin <seunguk.shin@samsung.com>
Tested-by: Seunguk Shin <seunguk.shin@samsung.com>
Cc: Seunguk Shin <seunguk.shin@samsung.com>
Cc: Jens Axboe <axboe@fb.com>
Cc: Kent Overstreet <kent.overstreet@gmail.com>
Cc: <stable@vger.kernel.org> # v3.14+
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@fb.com>
block/bio.c