projects / GitHub / moto-9609 / android_kernel_motorola_exynos9610.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: ad698ea) | patch
mfd: intel_soc_pmic_bxtwc: 64 bit bug in bxtwc_val_store()
authorDan Carpenter <dan.carpenter@oracle.com>
Mon, 28 Sep 2015 09:56:36 +0000 (12:56 +0300)
committerLee Jones <lee.jones@linaro.org>
Fri, 30 Oct 2015 17:19:47 +0000 (17:19 +0000)
commitf3a654c5198b1de3e6241ab6a9d5c52295504970
tree5a939b645442150e64df5576fe889bac1697c6d1tree | snapshot (tar.gz zip)
parentad698ea425f90e4d09694c2cf7155cad4d7badb3commit | diff
mfd: intel_soc_pmic_bxtwc: 64 bit bug in bxtwc_val_store()

The call to kstrtoul() will corrupt memory on 64 bit systems because an
int is 4 bytes and a long is 8.

Also it's not a good idea to let users trigger a dev_err() because it
just ends up flooding /var/log/messages so I removed the printk.

Fixes: 2ddd2086ea9c ('mfd: add Intel Broxton Whiskey Cove PMIC driver')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/mfd/intel_soc_pmic_bxtwc.c diff | blob | blame | history