virtio_scsi: remove ACCESS_ONCE() and smp_read_barrier_depends()
authorMing Lei <tom.leiming@gmail.com>
Thu, 8 May 2014 07:23:45 +0000 (15:23 +0800)
committerChristoph Hellwig <hch@lst.de>
Mon, 19 May 2014 17:12:26 +0000 (19:12 +0200)
commitf259d9bdd2fb13926dd16ffacd3417d610c23e8c
treebeb1cc910276e95e9e8623366fca0a26fb76a570
parent27f344eb15dd0da80ebec80c7245e8c85043f841
virtio_scsi: remove ACCESS_ONCE() and smp_read_barrier_depends()

Access to tgt->req_vq is strictly serialized by spin_lock
of tgt->tgt_lock, so the ACCESS_ONCE() isn't necessary.

smp_read_barrier_depends() in virtscsi_req_done was introduced
to order reading req_vq and decreasing tgt->reqs, but it isn't
needed now because req_vq is read from
scsi->req_vqs[vq->index - VIRTIO_SCSI_VQ_BASE] instead of
tgt->req_vq, so remove the unnecessary barrier.

Also remove related comment about the barrier.

Signed-off-by: Ming Lei <tom.leiming@gmail.com>
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/scsi/virtio_scsi.c