projects / GitHub / LineageOS / G12 / android_kernel_amlogic_linux-4.9.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 91c2b1a) | patch
batman-adv: properly check pskb_may_pull return value
authorAntonio Quartulli <antonio@meshcoding.com>
Wed, 29 Jan 2014 23:12:24 +0000 (00:12 +0100)
committerAntonio Quartulli <antonio@meshcoding.com>
Mon, 17 Feb 2014 16:17:01 +0000 (17:17 +0100)
commitf1791425cf0bcda43ab9a9a37df1ad3ccb1f6654
tree168bc48d9894cdf33b3065ddc5982d44605b73c4tree | snapshot (tar.gz zip)
parent91c2b1a9f680ff105369d49abc7e19ca7efb33e1commit | diff
batman-adv: properly check pskb_may_pull return value

pskb_may_pull() returns 1 on success and 0 in case of failure,
therefore checking for the return value being negative does
not make sense at all.

This way if the function fails we will probably read beyond the current
skb data buffer. Fix this by doing the proper check.

Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
net/batman-adv/routing.c diff | blob | blame | history