[POWERPC] Fix atomicity of TIF update in flush_thread()
authorMathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Sat, 10 Mar 2007 08:23:03 +0000 (03:23 -0500)
committerPaul Mackerras <paulus@samba.org>
Fri, 16 Mar 2007 05:37:28 +0000 (16:37 +1100)
commitf144e7c7272bf527c380bffaa5e789dc28a09d8d
tree18139c591b245d3f60bd074ca7321ed111722596
parentdb98e0b434a6265c451ffe94ec0a29b8d0aaf587
[POWERPC] Fix atomicity of TIF update in flush_thread()

Fix atomicity of TIF update in flush_thread() for powerpc

Fixes it correctly with *_ti_thread_flag.

Race :

parent process executing :
sys_ptrace()
 (lock_kernel())
 (ptrace_get_task_struct(pid))
 arch_ptrace()
   ptrace_detach()
     ptrace_disable(child);
       clear_singlestep(child);
         clear_tsk_thread_flag(child, TIF_SINGLESTEP);
         (which clears the TIF_SINGLESTEP flag atomically from a different
          process)
 (put_task_struct(child))
 (unlock_kernel())

And at the same time, in the child process :
sys_execve()
 do_execve()
   search_binary_handler()
     load_elf_binary()
       flush_old_exec()
         flush_thread()
           doing a non-atomic thread flag update

Applies on 2.6.20.

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Signed-off-by: Paul Mackerras <paulus@samba.org>
arch/powerpc/kernel/process.c