iio: hid-sensors: Prevent crash during hot-unplug
authorSrinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Thu, 20 Sep 2012 00:15:00 +0000 (01:15 +0100)
committerJonathan Cameron <jic23@kernel.org>
Sat, 22 Sep 2012 09:07:34 +0000 (10:07 +0100)
commitf07b60b7c34b771431f1d00e783f29a3667ff5ee
treebafe8ebf6796ead4414ac0f8530c5c4e43d3e46f
parent24db0d75d3666b2aa5950a8bec0c1898929f2945
iio: hid-sensors: Prevent crash during hot-unplug

When hid sensor hub is unplugged, there is a crash in
iio_device_unregister_trigger_consumer.
In a typical IIO driver when remove is called, it will unregister and free
trigger and then it will call iio_device_free.
The function iio_trigger_free() will free the allocated memory for trigger.
If this trigger was assigned to iio_dev->trig, then it should be set to NULL.
Othewise when iio_device_free() is called later, it finally calls
iio_device_unregsister_trigger(), which checks for
       if (indio_dev->trig)
                iio_trigger_put(indio_dev->trig);
If indio_dev->trig is not set to NULL, it calls iio_trigger_put on a bad
pointer causing crash.
This scenerio can happen in any driver, which is storing trigger pointer in
iio_dev structure and following current procedure during remove.

Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
drivers/iio/common/hid-sensors/hid-sensor-trigger.c