target: Drop signal_pending checks after interruptible lock acquire
authorNicholas Bellinger <nab@linux-iscsi.org>
Tue, 19 May 2015 22:10:44 +0000 (15:10 -0700)
committerNicholas Bellinger <nab@linux-iscsi.org>
Tue, 19 May 2015 22:18:20 +0000 (15:18 -0700)
commitee7619f2eb21304dcc846b8dc8f8c3d6cbe11792
tree4aad4ca471d2d69afac62087a716c4aa83d71ce8
parent6c2faeaa0ecc67098106771cba8b7ed1e99a1b5f
target: Drop signal_pending checks after interruptible lock acquire

Once upon a time, iscsit_get_tpg() was using an un-interruptible
lock.  The signal_pending() usage was a check to allow userspace
to break out of the operation with SIGINT.

AFAICT, there's no reason why this is necessary anymore, and as
reported by Alexey can be potentially dangerous.  Also, go ahead
and drop the other two problematic cases within iscsit_access_np()
and sbc_compare_and_write() as well.

Found by Linux Driver Verification project (linuxtesting.org).

Reported-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
drivers/target/iscsi/iscsi_target.c
drivers/target/iscsi/iscsi_target_tpg.c
drivers/target/target_core_sbc.c