uprobes: Kill set_orig_insn()->is_swbp_at_addr()
authorOleg Nesterov <oleg@redhat.com>
Sun, 23 Sep 2012 19:30:44 +0000 (21:30 +0200)
committerOleg Nesterov <oleg@redhat.com>
Sat, 29 Sep 2012 19:21:54 +0000 (21:21 +0200)
commited6f6a50dc5f183c53e7b3b7fed4794bc50d9aa7
tree8ef3472db708804bb292a79752d0b04de8f2060d
parentcceb55aab73d2aea8f4d6f7414d2e1b647a3dacb
uprobes: Kill set_orig_insn()->is_swbp_at_addr()

Unlike set_swbp(), set_orig_insn()->is_swbp_at_addr() makes sense,
although it can't prevent all confusions.

But the usage of is_swbp_at_addr() is equally confusing, and it adds
the extra get_user_pages() we can avoid.

This patch removes set_orig_insn()->is_swbp_at_addr() but changes
write_opcode() to do the necessary checks before replace_page().

Perhaps it also makes sense to ensure PAGE_MAPPING_ANON in unregister
case.

find_active_uprobe() becomes the only user of is_swbp_at_addr(),
we can change its semantics.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
kernel/events/uprobes.c