mmc: via-sdmmc: Fix data race bug
authorMadhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
Sat, 22 Aug 2020 06:15:28 +0000 (11:45 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 5 Nov 2020 10:06:55 +0000 (11:06 +0100)
commited44f00ad39db369d3184204989f30741672b38a
treee2a00545ace158fe1a63fc2b955bfd6f42bef0cc
parentcf124810276985b7aa51ff094b0592b130e2fe06
mmc: via-sdmmc: Fix data race bug

[ Upstream commit 87d7ad089b318b4f319bf57f1daa64eb6d1d10ad ]

via_save_pcictrlreg() should be called with host->lock held
as it writes to pm_pcictrl_reg, otherwise there can be a race
condition between via_sd_suspend() and via_sdc_card_detect().
The same pattern is used in the function via_reset_pcictrl()
as well, where via_save_pcictrlreg() is called with host->lock
held.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
Link: https://lore.kernel.org/r/20200822061528.7035-1-madhuparnabhowmik10@gmail.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/mmc/host/via-sdmmc.c