iwlwifi: mvm: rs: fix success ratio comparison in rs_get_best_rate
authorEyal Shapira <eyal@wizery.com>
Mon, 21 Sep 2015 17:03:22 +0000 (20:03 +0300)
committerLuca Coelho <luciano.coelho@intel.com>
Mon, 5 Oct 2015 11:33:30 +0000 (14:33 +0300)
commited21a384bbd2b011289dd1b5cab7eebc7ebeda11
tree83ed17548c88cbd3b7b89ed56d1ef8d4f148aa65
parent40ce5ed1e9d5c80819733c4fdc40a2b6c531d981
iwlwifi: mvm: rs: fix success ratio comparison in rs_get_best_rate

success_ratio is actually 128 * SR in percentage while
IWL_MVM_RS_SR_NO_DECREASE is 85%. Fix this by using RS_PERCENT().
This bug caused the if branch to be always executed. This in turn
led to always selecting a rate, following a column switch, in which
the expected throughput would exceed the best expected current throughput.
In some scenarios where the success ratio isn't >85% such a rate
could be too aggressive leading us to avoid the new column.
This has the potential of causing sub optimal performance.

Reported-by: Moshe Harel <moshe.harel@intel.com>
Signed-off-by: Eyal Shapira <eyalx.shapira@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
drivers/net/wireless/iwlwifi/mvm/rs.c