powerpc: Convert cmp to cmpd in idle enter sequence
authorSegher Boessenkool <segher@kernel.crashing.org>
Thu, 6 Oct 2016 13:42:19 +0000 (13:42 +0000)
committerWilly Tarreau <w@1wt.eu>
Wed, 7 Jun 2017 22:46:50 +0000 (00:46 +0200)
commitecf33babd51448a7390dff6adb17cbf8e196383c
tree4da3c2ccc9ce1cdfcc51965412190263addbb2d8
parent029555a52a2bcc709ed6ad6b1c8b208f53011f9f
powerpc: Convert cmp to cmpd in idle enter sequence

commit 80f23935cadb1c654e81951f5a8b7ceae0acc1b4 upstream.

PowerPC's "cmp" instruction has four operands. Normally people write
"cmpw" or "cmpd" for the second cmp operand 0 or 1. But, frequently
people forget, and write "cmp" with just three operands.

With older binutils this is silently accepted as if this was "cmpw",
while often "cmpd" is wanted. With newer binutils GAS will complain
about this for 64-bit code. For 32-bit code it still silently assumes
"cmpw" is what is meant.

In this instance the code comes directly from ISA v2.07, including the
cmp, but cmpd is correct. Backport to stable so that new toolchains can
build old kernels.

Fixes: 948cf67c4726 ("powerpc: Add NAP mode support on Power7 in HV mode")
Reviewed-by: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>
Signed-off-by: Segher Boessenkool <segher@kernel.crashing.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Joel Stanley <joel@jms.id.au>
Signed-off-by: Willy Tarreau <w@1wt.eu>
arch/powerpc/kernel/idle_power7.S