mmc: sdhci: Do not disable interrupts while waiting for clock
authorAdrian Hunter <adrian.hunter@intel.com>
Mon, 20 Mar 2017 17:50:29 +0000 (19:50 +0200)
committerWilly Tarreau <w@1wt.eu>
Tue, 20 Jun 2017 12:04:35 +0000 (14:04 +0200)
commitecf229c3de27f918fede7409aaf4cbde471ecb27
tree44c55502ba1223edcfe1910bc5220b4d4e0334a9
parent7eb0374df6d09b065f7b8e5eeb6daea5001e56c9
mmc: sdhci: Do not disable interrupts while waiting for clock

commit e2ebfb2142acefecc2496e71360f50d25726040b upstream.

Disabling interrupts for even a millisecond can cause problems for some
devices. That can happen when sdhci changes clock frequency because it
waits for the clock to become stable under a spin lock.

The spin lock is not necessary here. Anything that is racing with changes
to the I/O state is already broken. The mmc core already provides
synchronization via "claiming" the host.

Although the spin lock probably should be removed from the code paths that
lead to this point, such a patch would touch too much code to be suitable
for stable trees. Consequently, for this patch, just drop the spin lock
while waiting.

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Tested-by: Ludovic Desroches <ludovic.desroches@microchip.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Signed-off-by: Willy Tarreau <w@1wt.eu>
drivers/mmc/host/sdhci.c