[media] mb86a20s: apply mask to val after checking for read failure
authorColin Ian King <colin.king@canonical.com>
Fri, 15 Jul 2016 15:59:15 +0000 (12:59 -0300)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Fri, 15 Jul 2016 16:32:58 +0000 (13:32 -0300)
commiteca2d34b9d2ce70165a50510659838e28ca22742
treecd82afca63419c2b941af41f288d87a42deb9233
parent785ef73dba6e9fefd2e5dd24546e0efa8698e5cd
[media] mb86a20s: apply mask to val after checking for read failure

Appling the mask 0x0f to the immediate return of the call to
mb86a20s_readreg will always result in a positive value, meaning that the
check of ret < 0 will never work.  Instead, check for a -ve return value
first, and then mask val with 0x0f.

Kudos to Mauro Carvalho Chehab for spotting the mistake in my original fix.

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/dvb-frontends/mb86a20s.c