bpf: drop refcount if bpf_map_new_fd() fails in map_create()
authorPeng Sun <sironhide0null@gmail.com>
Wed, 27 Feb 2019 14:36:25 +0000 (22:36 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 5 Dec 2019 14:38:00 +0000 (15:38 +0100)
commitebf233fd40bfc70e53ac9ba6b46ec7b3439c3da1
treede550b9dbf033be578cde0a55e89dd1a4f7768f0
parent4e4a0cf997f8c40747bdf6465070f2bc04dcdc18
bpf: drop refcount if bpf_map_new_fd() fails in map_create()

[ Upstream commit 352d20d611414715353ee65fc206ee57ab1a6984 ]

In bpf/syscall.c, map_create() first set map->usercnt to 1, a file
descriptor is supposed to return to userspace. When bpf_map_new_fd()
fails, drop the refcount.

Fixes: bd5f5f4ecb78 ("bpf: Add BPF_MAP_GET_FD_BY_ID")
Signed-off-by: Peng Sun <sironhide0null@gmail.com>
Acked-by: Martin KaFai Lau <kafai@fb.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
kernel/bpf/syscall.c