ext4: use stream-alloc when mb_group_prealloc set to zero
authorRobin Dong <sanbai@taobao.com>
Wed, 26 Oct 2011 09:14:27 +0000 (05:14 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Wed, 26 Oct 2011 09:14:27 +0000 (05:14 -0400)
commitebbe027797f67d34708ccfabdb129886d549f9ce
tree0195f72d056bc00abd71fce86ce3d6507e1abe76
parentfcbb5515825f1bb20b7a6f75ec48bee61416f879
ext4: use stream-alloc when mb_group_prealloc set to zero

The kernel will crash on

ext4_mb_mark_diskspace_used:
BUG_ON(ac->ac_b_ex.fe_len <= 0);

after we set /sys/fs/ext4/sda/mb_group_prealloc to zero and create new files in an ext4 filesystem.

The reason is: ac_b_ex.fe_len also set to zero(mb_group_prealloc) in ext4_mb_normalize_group_request
because the ac_flags contains EXT4_MB_HINT_GROUP_ALLOC.

I think when someone set mb_group_prealloc to zero, it means DO NOT USE GROUP PREALLOCATION,
so we should set alloc-strategy to STREAM in this case.

Signed-off-by: Robin Dong <sanbai@taobao.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
fs/ext4/mballoc.c