cxlflash: Move to exponential back-off when cmd_room is not available
authorManoj N. Kumar <manoj@linux.vnet.ibm.com>
Fri, 25 Mar 2016 19:26:49 +0000 (14:26 -0500)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 29 Mar 2016 00:43:34 +0000 (20:43 -0400)
commitea76543127da32dec28af0a13ea1b06625fc085e
tree9112ed10ec3a8d4395f2964aa29510b7238dedc8
parent9526f36026f778e82b5175249443854c03b2e660
cxlflash: Move to exponential back-off when cmd_room is not available

While profiling the cxlflash_queuecommand() path under a heavy load it
was found that number of retries to find cmd_room was fairly high.

There are two problems with the current back-off:
a) It starts with a udelay of 0
b) It backs-off linearly

Tried several approaches (a higher multiple 10*n, 100*n, as well as n^2,
2^n) and found that the exponential back-off(2^n) approach had the least
overall cost. Cost as being defined as overall time spent waiting.

The fix is to change the linear back-off to an exponential back-off.
This solution also takes care of the problem with the initial
delay (starts with 1 usec).

Signed-off-by: Manoj N. Kumar <manoj@linux.vnet.ibm.com>
Acked-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Uma Krishnan <ukrishn@linux.vnet.ibm.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/cxlflash/main.c