tree-wide: convert open calls to remove spaces to skip_spaces() lib function
authorAndré Goddard Rosa <andre.goddard@gmail.com>
Tue, 15 Dec 2009 02:01:06 +0000 (18:01 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 15 Dec 2009 16:53:32 +0000 (08:53 -0800)
commite7d2860b690d4f3bed6824757c540579638e3d1e
tree84268ee28893256fd6a6a7e1d4474f61dbee74e7
parent84c95c9acf088c99d8793d78036b67faa5d0b851
tree-wide: convert open calls to remove spaces to skip_spaces() lib function

Makes use of skip_spaces() defined in lib/string.c for removing leading
spaces from strings all over the tree.

It decreases lib.a code size by 47 bytes and reuses the function tree-wide:
   text    data     bss     dec     hex filename
  64688     584     592   65864   10148 (TOTALS-BEFORE)
  64641     584     592   65817   10119 (TOTALS-AFTER)

Also, while at it, if we see (*str && isspace(*str)), we can be sure to
remove the first condition (*str) as the second one (isspace(*str)) also
evaluates to 0 whenever *str == 0, making it redundant. In other words,
"a char equals zero is never a space".

Julia Lawall tried the semantic patch (http://coccinelle.lip6.fr) below,
and found occurrences of this pattern on 3 more files:
    drivers/leds/led-class.c
    drivers/leds/ledtrig-timer.c
    drivers/video/output.c

@@
expression str;
@@

( // ignore skip_spaces cases
while (*str &&  isspace(*str)) { \(str++;\|++str;\) }
|
- *str &&
isspace(*str)
)

Signed-off-by: André Goddard Rosa <andre.goddard@gmail.com>
Cc: Julia Lawall <julia@diku.dk>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Jeff Dike <jdike@addtoit.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Richard Purdie <rpurdie@rpsys.net>
Cc: Neil Brown <neilb@suse.de>
Cc: Kyle McMartin <kyle@mcmartin.ca>
Cc: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: David Howells <dhowells@redhat.com>
Cc: <linux-ext4@vger.kernel.org>
Cc: Samuel Ortiz <samuel@sortiz.org>
Cc: Patrick McHardy <kaber@trash.net>
Cc: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
24 files changed:
arch/s390/kernel/debug.c
arch/um/drivers/mconsole_kern.c
arch/x86/kernel/cpu/mtrr/if.c
drivers/leds/led-class.c
drivers/leds/ledtrig-timer.c
drivers/md/dm-table.c
drivers/md/md.c
drivers/parisc/pdc_stable.c
drivers/platform/x86/thinkpad_acpi.c
drivers/pnp/interface.c
drivers/s390/block/dasd_proc.c
drivers/video/backlight/lcd.c
drivers/video/display/display-sysfs.c
drivers/video/output.c
fs/cachefiles/daemon.c
fs/ext4/super.c
kernel/params.c
lib/argv_split.c
lib/dynamic_debug.c
lib/vsprintf.c
net/irda/irnet/irnet.h
net/irda/irnet/irnet_ppp.c
net/netfilter/xt_recent.c
sound/pci/hda/hda_hwdep.c