bnx2x: Prevent load reordering in tx completion processing
authorBrian King <brking@linux.vnet.ibm.com>
Mon, 15 Jul 2019 21:41:50 +0000 (16:41 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 31 Jul 2019 05:28:44 +0000 (07:28 +0200)
commite57e990946b069c43393a436076f9e3d3554c6db
tree4348bc65fafc1dadd7893a6cdf32f90e454e5950
parent9ce0c09dc2fd49e239c8a5f6b18f3bb3e72c0145
bnx2x: Prevent load reordering in tx completion processing

[ Upstream commit ea811b795df24644a8eb760b493c43fba4450677 ]

This patch fixes an issue seen on Power systems with bnx2x which results
in the skb is NULL WARN_ON in bnx2x_free_tx_pkt firing due to the skb
pointer getting loaded in bnx2x_free_tx_pkt prior to the hw_cons
load in bnx2x_tx_int. Adding a read memory barrier resolves the issue.

Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.c