altera-stapl: check for a null key before strcasecmp'ing it
authorColin Ian King <colin.king@canonical.com>
Sat, 24 Nov 2018 12:34:10 +0000 (12:34 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 21 Dec 2019 09:41:09 +0000 (10:41 +0100)
commite490a04c4a91da62ae67235f4e7a586534562ee8
tree3d844f29b36346eb6ad437b49204e2a4cf56a5ee
parentdafd9e94580c6fdcc27b5750b6d2c1987ca46f5a
altera-stapl: check for a null key before strcasecmp'ing it

[ Upstream commit 9ccb645683ef46e3c52c12c088a368baa58447d4 ]

Currently the null check on key is occurring after the strcasecmp on
the key, hence there is a potential null pointer dereference on key.
Fix this by checking if key is null first. Also replace the == 0
check on strcasecmp with just the ! operator.

Detected by CoverityScan, CID#1248787 ("Dereference before null check")

Fixes: fa766c9be58b ("[media] Altera FPGA firmware download module")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/misc/altera-stapl/altera.c