lpfc: The lpfc driver does not issue RFF_ID and RFT_ID in the correct sequence
authorJames Smart <james.smart@avagotech.com>
Thu, 21 May 2015 17:55:16 +0000 (13:55 -0400)
committerJames Bottomley <JBottomley@Odin.com>
Fri, 5 Jun 2015 22:28:05 +0000 (15:28 -0700)
commite26422fe91e533cb0a51f5f5bf80856d40592e0d
tree30c356dff252cce90bc6dcac891c137053872322
parent6546a02a571c9e8c5c5e5c39b3acc25187002acc
lpfc: The lpfc driver does not issue RFF_ID and RFT_ID in the correct sequence

The order (it's a shall, but hard to dictate after the fact) is given in
FC-SCM - kind of.  SCM indicates what shall be implemented, lists it as (a),
(b), (c), but actually doesn't say it has to be in that order.  The only hard
requirement, called out in FCP-4, is that you must register your FC-4 Type
(via RFT_ID) before registering FC-4 Type Features (via RFF_ID), which makes
sense. We obviously violated this and there were some switches (or newer fw in
them) that enforced it.  The other rule of thumbs are: register your data with
the switch first, then register for SCRs, then do queries about the fabric,
with the SCRs telling you of changes post the queries.

Signed-off-by: Dick Kennedy <dick.kennedy@avagotech.com>
Signed-off-by: James Smart <james.smart@avagotech.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Sebastian Herbszt <herbszt@gmx.de>
Signed-off-by: James Bottomley <JBottomley@Odin.com>
drivers/scsi/lpfc/lpfc_hbadisc.c