netfilter: nf_queue: don't assume sk is full socket
authorFlorian Westphal <fw@strlen.de>
Fri, 25 Feb 2022 13:02:41 +0000 (14:02 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 8 Mar 2022 18:01:56 +0000 (19:01 +0100)
commite208bedb74b3f1487aea5590c4cad0cffc89dcc4
tree18214e38bcd16e062d46670cfaed874a0092ab79
parentab4fa0d4f8e721d8ca94c47512d2d6df69f44fb2
netfilter: nf_queue: don't assume sk is full socket

commit 747670fd9a2d1b7774030dba65ca022ba442ce71 upstream.

There is no guarantee that state->sk refers to a full socket.

If refcount transitions to 0, sock_put calls sk_free which then ends up
with garbage fields.

I'd like to thank Oleksandr Natalenko and Jiri Benc for considerable
debug work and pointing out state->sk oddities.

Fixes: ca6fb0651883 ("tcp: attach SYNACK messages to request sockets instead of listener")
Tested-by: Oleksandr Natalenko <oleksandr@redhat.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/netfilter/nf_queue.c